This repository was archived by the owner on Apr 11, 2026. It is now read-only.
refs #2620: Migrate screen-balance to ComposeViewModel#2801
Merged
ILIYANGERMANOV merged 2 commits intoIvy-Apps:mainfrom Oct 22, 2023
Merged
refs #2620: Migrate screen-balance to ComposeViewModel#2801ILIYANGERMANOV merged 2 commits intoIvy-Apps:mainfrom
ILIYANGERMANOV merged 2 commits intoIvy-Apps:mainfrom
Conversation
ILIYANGERMANOV
approved these changes
Oct 22, 2023
Member
ILIYANGERMANOV
left a comment
There was a problem hiding this comment.
Nice work 💯 Just make the events data object and we can merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) Checklist
Please check if your pull request fulfills the following requirements:
mainbranch.Screen_recording_20231022_152042.webm
What's changed?
Describe with a few bullets what's new:
Risk Factors
What may go wrong if we merge your PR?
In what cases your code won't work?
Does this PR closes any GitHub Issues?
Check Ivy Wallet Issues.
:screen-balanceto ComposeViewModel and our new architecture #2620Troubleshooting CI failures
If you see any of the PR checks failing (❌) go to Actions and find it there. Or simply click "Details" next to the failed check and explore the logs to see why it has failed.
Detekt
Detekt is a static code analyzer for Kotlin that we use to enforce code readibility and good practices.
To run Detekt locally:
If the Detekt errors are caused by a legacy code, you can suppress them using a basline.
Detekt baseline (not recommended)
Lint
We use the standard Android Lint plus Slack's compose-lints as an addition to enforce proper Compose usage.
To run Lint locally:
If the Lint errors are caused by a legacy code, you can suppress them using a basline.
Lint baseline (not recommended)
Unit tests
If this job is failing this means that your changes break an existing unit test. You must identify the failing tests and fix your code.
To run the Unit tests locally: